Skip to content

Conversation

@WarningImHack3r
Copy link
Contributor

@WarningImHack3r WarningImHack3r commented Feb 6, 2025

Description

Fix the --roundness CSS variable override in the Dark Note theme, which incorrectly targets the account menu's first child.

Current look on hover:
Current menu

The fix adds precision to the selector to avoid targetting .buttons that are children of .accountButtonAndMenu, fixing that very issue.
There might be other places this variable incorrectly impacts, but I don't know the codebase so any insight is welcome. If there's none but still a better/different selector to use, let me know too!

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Feb 6, 2025
@Miodec Miodec changed the title fix(dark-note): roundness variable affects account menu hover (@WarningImHack3r) style(dark note theme): fix roundness variable affecting account menu (@WarningImHack3r) Feb 7, 2025
@Miodec Miodec merged commit a3bbf21 into monkeytypegame:master Feb 7, 2025
16 checks passed
@Miodec
Copy link
Member

Miodec commented Feb 7, 2025

Thanks

@WarningImHack3r WarningImHack3r deleted the fix-account-menu-hover-radius branch February 7, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assets Languages, themes, layouts, etc. frontend User interface or web stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants